fix(runtime): add the missing ASF headers to the plugin modules - #3708
Conversation
`Check ASF source headers` fails on main. Five files added by #3250 carry no license header, so `main` and every branch built on it report a red CI run for a reason unrelated to their own changes. Generated by `node scripts/asf-license-headers.mjs write`; the header text is the standard one the script emits, and nothing else in these files changed.
zhiiw
left a comment
zhiiw
left a comment
There was a problem hiding this comment.
Verified at exact head b0a20d19c77b71128dc619a5ca6d1624cb759e2d: the diff is header-only (every added line is the ASF header comment, zero logic lines). I regenerated the headers independently on clean origin/main with node scripts/asf-license-headers.mjs write — the result is byte-identical to this PR's diff across all five files, and check then reports 2819 covered files all passing. test is completed/success on the exact head.
M4n5ter
left a comment
M4n5ter
left a comment
There was a problem hiding this comment.
Verified at exact head b0a20d1. Each of the five files adds the same standard 19-line ASF license header, and the remaining file contents are byte-identical to the base revision. The exact-head CI check is terminal and successful.
|
LGTM. The diff adds only the standard 19-line ASF license header to five files; with those lines removed the bodies are byte-identical to the base. 简体中文已确认。这个 diff 只是给五个文件加上标准的 19 行 ASF license header，去掉这些行后正文与 base 逐字节一致。当前 head 上 |
3 participants
Check ASF source headersis failing onmain, somainand every branch built on it currently report a red CI run for a reason unrelated to their own changes.Five files added by #3250 carry no license header:
#3250's own commit was already red for this, so the failure arrived with that merge rather than with anything after it.
This change is the output of
node scripts/asf-license-headers.mjs writeand nothing else — the standard header the script emits, added to those five files,+95lines and no logic change. After it,node scripts/asf-license-headers.mjs checkreports all 2819 covered files clean, which I verified on a clean checkout of currentmain.@likun666661 — you own #3250, so if you would rather land this yourself, please say so and I will close this. I opened it because
mainbeing red makes every other PR's CI harder to read, and this seemed worth unblocking quickly rather than waiting.简体中文
main上的Check ASF source headers正在失败，因此main以及所有基于它的分支，当前都会因为与自身改动无关的原因报出一次红色 CI。#3250 新增的五个文件没有版权头：
#3250 自己那个提交上的 CI 就已经是红的，所以这个失败是随那次合并到来的，不是之后的改动引入的。
本次改动就是
node scripts/asf-license-headers.mjs write的输出，除此之外没有别的内容——把脚本生成的标准版权头加到这五个文件上，+95行，零逻辑改动。之后node scripts/asf-license-headers.mjs check报告 2819 个受覆盖文件全部通过，我在当前main的干净检出上验证过。@likun666661 —— #3250 是你的，如果你更希望自己来修，说一声我就把这个关掉。我开这个 PR 是因为
main红着会让其他所有 PR 的 CI 结果难以判读，觉得值得尽快解开，而不是等。